search

nteract / commuter

🚎 Notebook sharing hub
BSD 3-Clause "New" or "Revised" License
495 stars 66 forks source link

Make S3 endpoint configurable #262

Open tongmingleee opened 5 years ago

tongmingleee commented 5 years ago

We would like to use commuter as a way to share notebooks on S3, but we are not using AWS S3 and there is no way to configure S3 endpoint. Can you make S3 endpoint configurable as environment variables? The change is easy and straightforward, would like to contribute to it.

brunowego commented 5 years ago

I have a similar issue, my infrastructure have MinIO, currently we have a mount point with NFS to the data folder.

captainsafia commented 5 years ago

Hello @tongminglee! Thanks for opening this issue.

Are you looking for S3 configuration options beyond those that exist currently? If so, happy to take a look at an example implementation you can provide in a PR.

withsmilo commented 5 years ago

@tongmingleee @brunowego @captainsafia I implemented it!

dazzag24 commented 5 years ago

Hi, Any plans to support other storage backends such as Azure blob storage?

Thanks Darren

captainsafia commented 5 years ago

@dazzag24 No implementation plans at the moment but PRs adding support for other storage backends are welcome!