search

nteract / commuter

🚎 Notebook sharing hub
BSD 3-Clause "New" or "Revised" License
495 stars 66 forks source link

Impl. GCS content provider. #274

Closed wutali closed 5 years ago

wutali commented 5 years ago

I added GCS content provider support Google Cloud Storage as a backend.

todo[bot] commented 5 years ago

typing here reflects what was put in place before, this could be

https://github.com/nteract/commuter/blob/90225744ea35283d88e2fe58bbec0048b4965776/backend/content-providers/gcs/contents.js#L11-L16

This comment was generated by todo based on a TODO comment in 90225744ea35283d88e2fe58bbec0048b4965776 in #274. cc @wutali.
wutali commented 5 years ago

@mpacer Do you have any idea about my PR? If you have some feedback before the merge, I want to fix it.

captainsafia commented 5 years ago

@rgbkrk or @cabhishek Are any of you available to review this?

rgbkrk commented 5 years ago

Let's just go for it.

rgbkrk commented 5 years ago

At Netflix we've been running an internal version so I'm happy to see people pushing the open-source version independently.