search

nteract / commuter

🚎 Notebook sharing hub
BSD 3-Clause "New" or "Revised" License
495 stars 66 forks source link

Modify isNotebook to deal with GCS responses #281

Closed shotarok closed 4 years ago

shotarok commented 4 years ago

What

Why

How to confirm

  1. Run env COMMUTER_STORAGE_BACKEND=gcs COMMUTER_BUCKET=commuter-shotarok-dev yarn dev
  2. Open http://localhost:4000/view/style_transfer/0.ipynb
shotarok commented 4 years ago

Thanks for your review! Me neither. I couldn't find any place to change in the file.

One concern is a description of the GCP credentials. We should add a subsection like "Environment Variables for S3 Storage" on README.md. Shall I add the description by this PR?

captainsafia commented 4 years ago

One concern is a description of the GCP credentials. We should add a subsection like "Environment Variables for S3 Storage" on README.md. Shall I add the description by this PR?

It's OK to do it in a separate PR. I'll go ahead and merge this one.

shotarok commented 4 years ago

Thanks. BTW, do you have a plan to make a new release on https://www.npmjs.com/package/@nteract/commuter?