search

nteract / kernelspecs

:card_index: Find Jupyter kernelspecs on a system
BSD 3-Clause "New" or "Revised" License
9 stars 11 forks source link

do not redefine a kernel spec with a lower precedence one #29

Closed haraldschilly closed 7 years ago

haraldschilly commented 7 years ago

see issue #28

The only new thing is the "if", the other part is a mockup python3 kernel and a line to test it.

rgbkrk commented 7 years ago

Excellent!

/cc @lgeiger -- we'll want to bring this into the monorepo merger too.

rgbkrk commented 7 years ago

I'm going to get the CI fixed up here.

rgbkrk commented 7 years ago

Thanks @haraldschilly!

haraldschilly commented 7 years ago

thank you for quickly reviewing it. will there be a new release with the fix?

rgbkrk commented 7 years ago

Yeah, I'm going to go ahead and get everything upgraded here as well as in other packages too: https://github.com/nteract/kernelspecs/pull/30

rgbkrk commented 7 years ago

Released v2.0.0 (as well as all the packages that depend on it within nteract).

rgbkrk commented 7 years ago

Harald, what's your username on npm? I'd love to add you to the @nteract org as well as the individual packages for kernelspecs and related packages that sage math cloud is relying on.

haraldschilly commented 7 years ago

@rgbkrk ok, I'm not active there (at least so far), but anyways: "hasch"

rgbkrk commented 7 years ago

Tis ok, I'm not handing you immediate responsibility to take care of anything, just the ability later. 😄