search

nteract / papermill

📚 Parameterize, execute, and analyze notebooks
http://papermill.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
5.99k stars 428 forks source link

Importing papermill fails due to "ModuleNotFoundError" #799

Closed AKShaw closed 5 months ago

AKShaw commented 5 months ago

🐛 Bug

When installing papermill, version 8.4.0 of tenacity gets installed as a dependency, but this has an issue that prevents the import from working correctly.

Steps to reproduce

From a fresh environment:

pip install papermill python import papermill > ModuleNotFoundError: No module named 'tenacity.asyncio'

This issue arises from the use of tenacity==8.4.0 - downgrading to tenacity==8.3.0 solves this issue. I think setting https://github.com/nteract/papermill/blob/main/requirements.txt#L8 to tenacity >= 5.0.2,<8.4.0 would solve this.

Feel free to reach out for any additional information!

JohnScolaro commented 5 months ago

Took down my CI pipeline. Keen to get resolved.

MSeal commented 5 months ago

Thanks for raising, if someone wants to open a PR I can get a release build going to patch the issue tonight.

JohnScolaro commented 5 months ago

Update: Tenacity already knows about it, (see issue here) and have pushed out a new patch fixing the issue.

Tenacity 8.4.0 is broken, but 8.4.1 is fixed. So we probably don't need to fix anything at all, and just upgrading to the latest version of tenacity is enough to fix the problem.

MSeal commented 5 months ago

Great, thanks for reporting the update. Going to close the issue here then