search

nteract / vdom

🎄 Virtual DOM for Python
https://github.com/nteract/vdom/blob/master/docs/mimetype-spec.md
BSD 3-Clause "New" or "Revised" License
222 stars 35 forks source link

[MRG] Remove unneeded postBuild #95

Closed betatim closed 5 years ago

betatim commented 5 years ago

Binder now runs pip install . automatically when there is a setup.py

rmorshea commented 5 years ago

@betatim does binder ignore the setup.py if you have postBuild?

betatim commented 5 years ago

No.

https://github.com/jupyter/repo2docker/blob/df89849e21a5c9d97d3b5a06dd049e8d18c7ec49/repo2docker/buildpacks/python/__init__.py#L69-L74

setup.py is like any other file recognised by repo2docker in that it can work together with other files. The way to ignore setup.py is to create a binder/ directory. The idea is to allow repositories that represent a Python package to "just work" with repo2docker and allow the authors of the repo to override the default behaviour by adding a binder/ directory that does what they want to do (for example install the latest released version or add additional dependencies needed for examples/tutorials).

rmorshea commented 5 years ago

@betatim I don't have merge rights on many Repos. If I perform the merge and do so via a merge-commit, will you be credited? If not, is it good etiquette to allow the author to merge their own pull requests?

betatim commented 5 years ago

If you press the big green button at the bottom of the PR page labelled "Merge pull request" things will work out as they should. You don't have to make any choice in the drop down menu associated with the button.