nthallen / monarch

Monarch Data Acquisition System
0 stars 1 forks source link

Multiple spec files in one directory #145

Open nthallen opened 3 years ago

nthallen commented 3 years ago

There are various reasons why one might want to have multiple instrument configurations defined within a single experiment:

Source control is also complicated where generated source files change with different configurations. Those files could be removed from source control easily enough, since they are in fact easily regenerated. Assuming the relevant compilers are fairly stable, having the source should be sufficient to know what the output files looked like, but it may be early to assume that.

nthallen commented 3 years ago

VERSION is now solved with Version module.

Setting prefix prevents creating multiple collection programs as noted above, but it does mean that all specs will produce $prefix.pcm, so we lose the benefit of having the pcm file in source control, which gives a useful check on whether a version bump is required. A solution could be as simple as specifying the PCMFILE in the .spec file.

Other generated code that comes and goes is a minor problem. The files get dropped from .gitignore, so then they show up as untracked in git status. They could be removed by make clean, but that does mean that the next run of make will require a rerun of appgen.

nthallen commented 3 years ago

If PCMFILE were spec-specific, saverun would need to be checked to make sure it saves the right one.

Alternately, make sure the prefix is actually different between different spec files.