ntt-sic / masakari

[UNMAINTAINED]

https://wiki.openstack.org/wiki/Masakari

Apache License 2.0

41 stars 25 forks source link

Add setuptools and rpm setup capabilities #21

Closed sampathP closed 8 years ago

sampathP commented 8 years ago

This patch add setuptools and rpm setup capabilities to masakari

Implement setuptools with pbr packaging feature for, masakari-controller and masakari-instancemonitor.

rpm spec files for each project and located under, [project_name]/rpmbuild/SPECS/*.spec systemd scripts are under, [project_name]/etc/systemd/system/[project_name].service

sampathP commented 8 years ago

To test this code, Pull request to send to masakari-deploy for related deploy patch. Or use following repo, Repo: https://github.com/sampathP/masakari-deploy/ Branch: feature/centos-support which is same as the above pull req.

muroi commented 8 years ago

Overall, LGTM. If possible, could you surround commands in README with sh or something like that to easy to read in github page.

sampathP commented 8 years ago

@muroi Thank you for the review. markdown the README is done.

toshikazu0314 commented 8 years ago

looks good to me. Just need to resolve conflicts.

sampathP commented 8 years ago

Conflicts resolved

sampathP commented 8 years ago

18 and this PR add .gitignore file but file content is slightly different.

I could rebase, but it will flush all the comment messages on this PR. So, I will push a another patch for .gitignore after merge this.