nuagenetworks / nuage-metroae

Nuage Networks Metro Automation Engine
http://devops.nuagenetworks.net
Apache License 2.0
44 stars 17 forks source link

hosts file format in 2.4? #631

Closed hellt closed 6 years ago

hellt commented 6 years ago

Hi all, what is the semantics that we should adhere in the hosts file?

I see some strange things with the group names... For instance there is not group [vsds] and at the same time we have [vsds:children]

The reason I ask is to understand how should we propose a PR for multiple (>2) VSCs. Seems like the merged PR !630 could not be the proper way to state VSCs. Do we need to use vsc_nodeX syntax instead?

/cc @bacastelli @brncoguz

ghost commented 6 years ago

vsds and vsds:children are alternate equivalent syntax for the same thing: a group named 'vsds'. The way the vscs group is formed is to use vsc_node1 if and only if the number of vscs is one or two. This is the :children syntax. This is required for upgrade. Otherwise, for larger numbers of vscs, we make a simple list of dictionaries without vsc_node1 and :children syntax.

On Sun, May 20, 2018, 2:05 PM Roman Dodin notifications@github.com wrote:

Hi all, what is the semantics that we should adhere in the hosts file?

I see some strange things with the group names... For instance there is not group [vsds] https://github.com/nuagenetworks/nuage-metro/blob/dev/roles/build/templates/hosts.j2#L8 and at the same time we have [vsds:children] https://github.com/nuagenetworks/nuage-metro/blob/dev/roles/build/templates/hosts.j2#L15

The reason I ask is to understand how should we propose a PR for multiple (>2) VSCs. Seems like the merged PR !630 could not be the proper way to state VSCs. Do we need to use vsc_nodeX syntax instead?

/cc @bacastelli https://github.com/bacastelli @brncoguz https://github.com/brncoguz

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nuagenetworks/nuage-metro/issues/631, or mute the thread https://github.com/notifications/unsubscribe-auth/ARgJcP50_B7eScfi3L_nTZuTm5mc4g8-ks5t0bBNgaJpZM4UGKhF .

hellt commented 6 years ago

Ok got it, thanks