remove env.sh - Githubissues

nulpunkt / yesql-php

A clone of the wonderful yesql clojure library, for php

23 stars 7 forks source link

Closed K41R1 closed 6 years ago

K41R1 commented 6 years ago

hi, i suggest to use composer script https://getcomposer.org/doc/articles/scripts.md#writing-custom-commands instead of redefining the global variable $PATH

nulpunkt commented 6 years ago

Hey,

That's a great idea! Could you please fix the indentation under require-dev? I'd be more than happy to merge this.

K41R1 commented 6 years ago

Hi, i will fix later.. i also suggest to migrate to phpunit 6.5 it's a stable release

nulpunkt commented 6 years ago

Yeah, I should probably upgrade phpunit as well :)

nulpunkt commented 6 years ago

I'm closing this now, please feel free to return with another pr!