search

numenta / nupic-legacy

Numenta Platform for Intelligent Computing is an implementation of Hierarchical Temporal Memory (HTM), a theory of intelligence based strictly on the neuroscience of the neocortex.
http://numenta.org/
GNU Affero General Public License v3.0
6.34k stars 1.56k forks source link

fix asterisk password bug in test_db.py #3731

Closed pianomanfrazier closed 7 years ago

pianomanfrazier commented 7 years ago

The password is being submitted as all asterisks to the database instead of the actual password.

rhyolight commented 7 years ago

Wow, how could this have been working? cc @scottpurdy @vitaly-krugl ?

vitaly-krugl commented 7 years ago

Interns!! :) Hmmm... I wonder ... when MySQL is configured for no password for a given user, does it possibly ignore the password??

cc @rhyolight

vitaly-krugl commented 7 years ago

@pianomanfrazier, @rhyolight: Also, the existing logic is not at all pythonic. The call to testDbConnection returns True/False instead of raising an exception. So, even if this example test is running in CI and DB connection fails, the app would simply print a message on failure, but not communicate the failure via process exist code, so higher-level test driver has no clue that something is amiss.

rhyolight commented 7 years ago

Thanks Vitaly. @pianomanfrazier let me know of you want to go the extra mile as suggested, otherwise I will merge this as-is.

rhyolight commented 7 years ago

Well shit, I screwed up. @pianomanfrazier You are supposed to sign our contributor license before I merge. Do you mind doing that now?

Just in case, I reverted this accidental merge (all I can do at this point). @pianomanfrazier Once you sign the license I'll take care of this and get it re-merged.

Sorry for the hassle! Apparently there is something wrong with our automated contributor validator. I'll be looking into it.

pianomanfrazier commented 7 years ago

Just signed the license.

rhyolight commented 7 years ago

Thanks, it takes a bit to process. I'll check back in later.

rhyolight commented 7 years ago

@pianomanfrazier I have your CL now. I'm not sure you can re-open this PR, but you can push your changes to a new remote branch and create a new PR to address @vitaly-krugl's changes.