Closed utensil closed 10 years ago
There's one way to fix this issue, as I tried in #756 : we can confirms $NTA != $NUPIC after applying defaults to them.
Reasoning:
@utensil Good catch! Thanks for your contribution and trying to follow our process. You've been added as a contributor now, so your PRs should pass.
@david-ragazzi This makes sense to me. Do you have an opinion?
@david-ragazzi This makes sense to me. Do you have an opinion?
Yes, a good observation by @utensil . I also had same problems when these variables were empty.. So the change proposed is need.. Although that in new version of CMake file (https://github.com/numenta/nupic/pull/751), CMake configures every time $NTA and $NUPIC using default values ($REPOSITORY/build/release
and $REPOSITORY
folders, which can be changed by command line). This makes that these variables never will be empty..
@utensil Please, keep on eye on https://github.com/numenta/nupic/pull/751 , and let us know if this error remains even in the version of CMake file.. Your help is appreciate..
@david-ragazzi Glad to see #751 further promote the forming of nupic.core
, it's really excellent work. First time I encounter nupic
, excited by its beauty, it took me quite a while to figure out what's going on in all directories, and I just felt puzzled and a little frustrated. And now, a more clear structure is showing a brighter future for the community to get involved.
I'll try #751 soon.
First time I encounter nupic, excited by its beauty, it took me quite a while to figure out what's going on in all directories, and I just felt puzzled and a little frustrated. And now, a more clear structure is showing a brighter future for the community to get involved.
@utensil Uow.. Read this is really motivating! Because this was what I have in mind, i.e. decreasing the learning curve by put the things in a structure easy to follow and so more people get involved.. :-)
:metal:
http://www.youtube.com/watch?v=AHb4gs1hwck :japanese_ogre:
:metal:
I love that one.
Matt Taylor OS Community Flag-Bearer Numenta
On Wed, Apr 2, 2014 at 10:15 AM, David Ragazzi notifications@github.comwrote:
http://www.youtube.com/watch?v=AHb4gs1hwck [image: :japanese_ogre:]
[image: :metal:]
Reply to this email directly or view it on GitHubhttps://github.com/numenta/nupic/issues/755#issuecomment-39357355 .
I love that one.
:smile:
@utensil Is this bug still valid?
Though there's still a lot of discussions related to this issue, this issue is no longer describing an issue of nupic@HEAD, so I'll close it.
The discussion continues at hackers' ML, and some of my opinions are expressed at https://github.com/numenta/nupic/issues/790#issuecomment-40035027 and https://github.com/numenta/nupic/pull/801#issuecomment-40172540 .
In
README.md
:This is an usability improvement compared to the old "set $NUPIC and $NTA yourself or the build fails" approach, providing sane defaults in the spirit of 2014 Goals For NuPIC: Easy install, easy build.
But when $NTA and $NUPIC are both empty,
cmake $REPOSITORY
complains:In
CMakeLists.txt:181
, it reads:This logic fixes #659 , but is in contradiction to with the statements in
README.md
, which implemented aroundCMakeLists.txt:436
:Thus, as long as they are not both empty, defaults would work.
And I noticed in .travis.yml,
$NUPIC
and$NTA
are declare inenv.global
, and I guess most nupic developers already have them configured, that's why it's not spotted.