search

numerique-gouv / impress

MIT License
13 stars 8 forks source link

Switch from Web Sockets to Long polling #437

Open virgile-dev opened 3 days ago

virgile-dev commented 3 days ago

Bug Report

Problematic behavior Websockets are not compatible with internal networks and security configuration.

Expected behavior/code Replace websocket with Long Polling. Which means we need to make changes to hoccus poccus and Y.js

YousefED commented 2 days ago

Thanks for adding this. Did we confirm this is really the issue for certain users?

Kevin's first thoughts on this are here: https://github.com/ueberdosis/hocuspocus/issues/95#issuecomment-2464683300 and this specifically might be concerning:

A quick web search revealed that the very same Antivirus software that can do this if (mis)configured, also blocks long-pulling

I'm quite sure we can add support for it but it will be quite a bit of work - so it would be great if we can test whether it actually fixes the issue for those setups