search

numical / script-ext-html-webpack-plugin

Enhances html-webpack-plugin functionality with different deployment options for your scripts including 'async', 'preload', 'prefetch', 'defer', 'module', custom attributes, and inlining.
MIT License
588 stars 105 forks source link

1.4.1 #7

Closed JustAboutJeff closed 7 years ago

JustAboutJeff commented 7 years ago

Thanks for creating script-ext-html-webpack-plugin! This PR adds support for using the inline option alongside a publicPath webpack configuration, corrects a few spec descriptions, and bumps a patch version for release.

numical commented 7 years ago

Brill! Thanks so much.
I'll make one minor change and get this merged. The minor change is stylistic only - I consider the ~x.indexOf() a little unintuitive (and easy to miss when parsing code) so will replace it will the clunky-but-obvious x.indexOf() > -1.

JustAboutJeff commented 7 years ago

Thanks @numical. I pushed up an amended commit that includes a more readable String.prototype.includes approach. Initially I wasn't sure about the node support but it does look like it is available back through 4.3.2.

numical commented 7 years ago

The includes approach would have been nice - had I seen it before I pulled the branch and released the updated 1.4.1. Ahem. I will put it into the next release, along with the forgotten credit to yourself in the README. Thanks again @JustAboutJeff