search

numixproject / numix-icon-theme

Official base icon theme from the Numix project.
http://numixproject.github.io
GNU General Public License v3.0
778 stars 87 forks source link

Symbolic icons too small for GNOME headerbars #1404

Open palob opened 3 years ago

palob commented 3 years ago

GNOME upstream introduced revised symbolic icons which will use the full 16x16canvas. https://blogs.gnome.org/alexm/2021/09/10/cleaning-up-header-bars/

Some our themed icons (which aren't distinguishable from upstream Adwaita design-style-wise for the simple reason there is noo room for a distinct Numixy design with symbolic icons) might look too small in comparison.

I did not run into problems so far, just something to keep an eye on.

palob commented 2 years ago

Now that the change has landed our icon do look comparatively small indeed. My (radical) proposition to go forward is to just remove our GNOME symbolic icons and inherit them from Adwaita since (apart from the size) design-wise only die-hard icon expert could tell the difference.

Will this effectively introduce a dependency on Adwaita for our theme? Are those icons used outside of GNOME? If so, we may need to inherit from more themes.

At least on Arch gtk3/4 have adwaita-icon-theme as dependency so Adwaita will be installed as soon you're using GTK apps.

Foggalong commented 2 years ago

Aghhhh. Do you have a screenshot of how it looks with Numix? I'm still stuck on 3.36 over here.

Re dependencies, ditto in Ubuntu, Adwaita is the a GTK app dependency and I'd be surprised if this wasn't the case in Fedora also. Sounds like we'd only really be adding a "new" dependency for KDE and LXQt people who don't use any GTK apps.

Screenshot from 2022-05-10 15-40-11

In terms of what would need changing, is this "just" the 516 icons ending in -symbolic.svg or is it something else?

palob commented 2 years ago

I actually need to investigate some more. I don't know who exactly outside of GNOME uses symbolic icons (those with -symbolic in the file name) and where.

AFAIK KDE Breeze icon look like symbolic icons but aren't technically ones (not according to the GNOME definition).

palob commented 1 year ago

People who don't use a single GTK app probably won't need the symbolic icons in questions for their apps. Anyway, apps will ship their icons (by themselves or dependencies) and as long as icons named *-symbolic are actually designed in a monochrome/oligochrome (symbolic in the "GNOME" meaning) way, Numix theming will only introduce that faint visual change.