Require `params.id` when pushing results to client

numo-labs / aws-lambda-helper

:lollipop: Collection of helper methods for lambda

GNU General Public License v3.0

22 stars 2 forks source link

Require `params.id` when pushing results to client #56

Closed lennym closed 8 years ago

lennym commented 8 years ago

The websocket server cannot reconcile results with the client if no room id is provided. This means that it should not be possible to call pushResultToClient without an id property on the parameters sent.

lennym commented 8 years ago

I'll leave it up for discussion whether this should be a major, minor or patch version update...

It has the potential to be a breaking change, but only to things that are already broken, so my instinct would be a patch change.

nelsonic commented 8 years ago

@lennym agreed. patch. 👍

codecov-io commented 8 years ago

Current coverage is 100%

Merging #56 into master will not change coverage

@@             master        #56   diff @@
==========================================
  Files             1          1          
  Lines           149        153     +4   
  Methods          25         25          
  Messages          0          0          
  Branches         28         29     +1   
==========================================
+ Hits            149        153     +4   
  Misses            0          0          
  Partials          0          0

Powered by Codecov. Last updated by a03f322...da980ad

nelsonic commented 8 years ago

Code looks good. thanks for adding that regression test. 👍 merging.