numo-labs / aws-lambda-helper

:lollipop: Collection of helper methods for lambda
GNU General Public License v3.0
22 stars 2 forks source link

Use lltrace to trace our lambdas #66

Closed tomgco closed 8 years ago

codecov-io commented 8 years ago

Current coverage is 96.82%

Merging #66 into master will increase coverage by 0.10%

@@             master        #66   diff @@
==========================================
  Files             2          2          
  Lines           183        189     +6   
  Methods          27         26     -1   
  Messages          0          0          
  Branches         42         44     +2   
==========================================
+ Hits            177        183     +6   
  Misses            6          6          
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by cb23b30...1e6ce77

hassy commented 8 years ago

@nelsonic can we merge this + push a release (a pre-release version perhaps) so that we can experiment with enabling tracing for our lambdas one by one?

EDIT: actually, it's not going to work yet, do not merge. :)

hassy commented 8 years ago

Should be good to merge now @nelsonic

nelsonic commented 8 years ago

Gents the code looks good, however the new dependency lltrace-aws-sdk does not appear to have any tests ... is this on the backlog?

hassy commented 8 years ago

Yep it is. 👍

nelsonic commented 8 years ago

Cool. ok. let's merge + publish this version so you can get on with your work... please let us know when there ar tests for lltrace-aws-sdk 👍