nus-cs2103-AY1920S1 / pe-dev-response

0 stars 0 forks source link

Finance Tracker: Error in calculation #1559

Open nus-pe-bot opened 5 years ago

nus-pe-bot commented 5 years ago

add-paid d/astons for lunch a/1000000000000000000000000000000000000001 will not input $1000000000000000000000000000000000000001 but $1000000000000000000000000000000000000000.00 instead.

Also expenses this month will output the wrong value.

Steps to reproduce bug

  1. add-paid d/Astons for lunch a/100000000000000000000000000000000000000

Screenshot 2019-11-15 at 4.34.16 PM.png

  1. add-paid d/astons for lunch a/1000000000000000000000000000000000000001

Screenshot 2019-11-15 at 4.35.07 PM.png

  1. Expenses this month will not show the correct total revenue.

Screenshot 2019-11-15 at 4.35.54 PM.png


[original: nus-cs2103-AY1920S1/pe-interim#1568]

gohsnn commented 5 years ago

Team's Response

Noted, however this flaw would unlikely affect normal operations of the product as Jarvis is meant to track the monthly expense of a student. Furthermore, it is unlikely that a student would spend $1000000000000000000000000000000000000001 in a single use payment.

Duplicate status (if any):

Duplicate of #2148