search

nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Editing the fields in the JSON data file to be null crashes the app #2266

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

Screenshot 2021-11-12 at 5.05.39 PM.png

Screenshot 2021-11-12 at 5.06.34 PM.png

As seen in the screenshots, editing one of the fields in the data file to be null will cause the app to crash, and not start. While this might not happen to most users, some users may want to edit the JSON file like this and this may cause inconvenience for them.

[original: nus-cs2103-AY2122S1/pe-interim#2231] [original labels: severity.Low type.FunctionalityBug]

SpdPnd98 commented 2 years ago

Team's Response

...some users may want to edit the JSON file like this ...

The term "like this" does not have a clear context, and the developers will assume the tester means that the users are trying to achieve something by putting a value of null.

To evaluate whether this should be accepted as a bug, we have to understand the purpose of the user entering null into the square brackets. The only explanation would be that tester wants to clear the schedules by directly editing the JSON file. This should not happen often, if at all, to the user.

If a user were to have the confidence to edit the JSON file directly, we can safely assume that they understand the significance of not abiding by the original format of the storage file, understand the square brackets in the file means an array and the significance of putting in a value of null within said square brackets.

The example provided is henceforth a form of intentional sabotage, and should therefore be rejected.

Duplicate status (if any):

--