search

nus-cs2103-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Auto Decapitalisation #3072

Open nus-pe-bot opened 3 years ago

nus-pe-bot commented 3 years ago

When the command

add /g Poker /s 500 /e 650 /date 2021-06-21 /dur 35791395 /loc ggbet.com/index.html?session=AwcEa123saGaslt

is entered, the URL

ggbet.com/index.html?session=AwcEa123saGaslt

is automatically formatted to only have the first letter capitalised. This is stated as a feature in the user guide, but I believe taking away this ability to self-format the text is less beneficial to the end user, since the uniform formatting does not add any value to the user's experience, and could make it harder for them to find a specific location that is always displayed with fixed formatting. If the user is gambling online, the website URL could also be broken from this use case. Examples are attached below, where a case-sensitive URL could be broken.

Attached below are the screenshots of the command output and new entry created:

image.png

image.png

[original: nus-cs2103-AY2122S1/pe-interim#3040] [original labels: severity.Low type.FeatureFlaw]

yzhilong commented 3 years ago

Team's Response

Agreed that locations that represent URLs will be auto-capitalized when, which is not what the user would want, but this does not break a URL since they are case-insensitive before the domain name (the .com/.net/.org part). The location is also not meant to be a URL, though it is understandable that the user might input that. Since the URL will still work, this is merely a cosmetic issue, hence I think it should be very low instead of low, as per the pe guide.

Duplicate status (if any):

--