search

nus-cs2103-AY2223S2 / pe-dev-response

1 stars 0 forks source link

Tampering with JSON file for certain fields allowed #3080

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

When the app uses the JSON file to load data, and a certain patient's contact is updated to a non-personal contact number (i.e. 999), the app allows it and does not validate the number that it is a personal/landline number.

Screenshot 2023-04-14 at 2.38.30 PM.png

[original: nus-cs2103-AY2223S2/pe-interim#4059] [original labels: severity.Low type.FeatureFlaw]

Emrysil commented 1 year ago

Team's Response

This is a feature of our app. Our app does not check the validity of a number because while one number might be a landline number in Singapore, it might be a perfectly fine number in a different country. We want to keep our options open as we are not aiming only for Singapore's market. So we'll leave it to the receptionists' discretion.

Duplicate status (if any):

--