search

nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

'update' command: Adding attendees to an event and changing the name of said event to a duplicate does not detect duplicates #112

Open nus-pe-bot opened 2 weeks ago

nus-pe-bot commented 2 weeks ago

To replicate:

  1. event -n Test -sd 2023-10-15 -ed 2023-10-18 -l Home
  2. event -n Teste -sd 2023-10-15 -ed 2023-10-18 -l Home
  3. update -i (index of Test) -a 1
  4. update -i (index of Test) -n Teste

Expected: Event name will not be updated as it will cause a duplicate event.

Actual: image.png

When adding an attendee to an event, it classifies it as a different event when changing all the other prefixes to match another event. Perhaps exclude attendees as a prefix to detect duplication?

I am aware of the below and believe that they both are separate issues or an update to the below is needed:

image.png

[original: nus-cs2103-AY2425S1/pe-interim#159] [original labels: severity.Medium type.FeatureFlaw]

michaelyql commented 2 weeks ago

Team's Response

This is an intended feature of the application.

We leave as much freedom as possible to the user, and only report a duplicate if the exact fields of two events match, plus the list of attendees are matching exactly as well.

For example, say there is an upcoming event for Chinese New Year, and the user wants to separate contacts into their respective family groups, instead of adding all the contacts from different families under the same event.

The application would allow them to have two different events, both called Chinese New Year with a location Home on the same date, but with two different set of attendees.

This way, the user can easily differentiate between the different families that are coming to celebrate Chinese New Year, without the hassle of having to search through the attendee list of one single event, just because we were too strict with duplicate checking.

Duplicate status (if any):

--