nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

person contains phone number and address fields #1341

Open nus-pe-bot opened 2 weeks ago

nus-pe-bot commented 2 weeks ago

Target users: The target users are for gamers who have friends across different games

potential bug As a gamer myself, some of these friends that I want to save contacts for are those that I have met online and played many games together, which is why I would know them by their username instead of their actual name. I would also not know their address and phone number(which makes me kinda like a stalker). However, under the person field, there are still these options available.

Suggestion: Remove those fields completely to make the interface look cleaner. Could also replace these fields with instagram handle etc.


[original: nus-cs2103-AY2425S1/pe-interim#1853] [original labels: type.FeatureFlaw severity.Low]

Xczheng0105 commented 2 weeks ago

Team's Response

There are a few reasons why we chose to keep fields like Address and Phone. Firstly, keeping Address can come in handy when one wants to go over to their friend's place to play but has forgotten their address. In this case, having their gaming contact's physical address stored would be useful. Secondly, Phone may be useful in some situations such as Discord being down. In that case, gamers still have a way to reach each other. Additionally, having an extra method of contacting another gamer is just one more layer of assurance so that one has ways to check in on their friends if anything.

Additionally, we have decided to make these fields optional. If you do not have their address or phone, it is perfectly find to omit them.

image.png

As can be seen from the screenshot, the optional fields will not show up in the UI if omitted. Hence the feature(s) are working as intended, and we will reject this bug.

Duplicate status (if any):

--