search

nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Editing person with their own info #1644

Open nus-pe-bot opened 2 weeks ago

nus-pe-bot commented 2 weeks ago

Summary

Editing a person with their same info is allowed.

User's may occasionally try to make small changes but ends up using the same info accidentally. Perhaps a helpful error can be thrown to prevent editing with the exact same info

Steps to Reproduce

  1. Edit a person with their own name :ed 1 -n[THEIR OWN NAME]
  2. Operation is allowed

Screenshots

image.png

image.png

Please ignore the syntax error for the first screenshot. Its supposed to be :ed 14 -n jOHN

Reasoning for Severity

This may occationally happen, but will not cause too much of an inconvenience apart from being a bit waste of time for users.

[original: nus-cs2103-AY2425S1/pe-interim#2263] [original labels: type.FeatureFlaw severity.Low]

anselmlong commented 1 week ago

Team's Response

Hello, thanks for reviewing our product!

However, this behavior aligns with the current scope of the system. Allowing edits, even with identical information, ensures that users can confirm and save changes without unnecessary interruptions. In some cases, users may edit and re-save a contact’s details to confirm accuracy or resolve formatting inconsistencies that are not immediately visible.

While we understand that an error message could help some users in specific situations, implementing such functionality falls outside the current priorities for our system. That said, we appreciate your suggestion and will consider it for future improvements if we notice significant demand for this enhancement.

Hope this clarifies your queries, thanks for testing our product!

Duplicate status (if any):

--