nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Preceding zeroes for year group field is not allowed #2176

Open nus-se-script opened 2 weeks ago

nus-se-script commented 2 weeks ago

the parameter yg\02 is not accepted when using the add command

image.png

02 has the value 2, which is between 1 and 13. However, the input 02 is not accepted for the year group. There may be times when year groups are written in 2 digit format, such as 02, 05 or 07, but this app does not accept such input with preceding zero. User guide also did not mention that preceding zeros are not allowed.


[original: nus-cs2103-AY2425S1/pe-interim#2968] [original labels: severity.Low type.FunctionalityBug]

JoanneHing commented 2 weeks ago

Team's Response

Thank you for your feedback.

Screenshot 2024-11-18 at 12.36.59 AM.png

We agree that 02 has the value 2 also. But as provided above, in our user guide we mentioned that only number 1-13 is allowed, not value that is between 1-13 or number 01-13. Besides we also gave example inputs of year group where we used 1,2,3,4 instead of 01,02,03,04 as example single digit numbers.

We believe this is a NotInScope bug as the UG specifies that only number 1-13 is supported and if the user tries to use input such as 01 the error message will inform the user that only 1-13 is allowed.

Duplicate status (if any):

--