nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Allowing one domain label in emails #2250

Open nus-pe-bot opened 1 week ago

nus-pe-bot commented 1 week ago

Steps to reproduce: add a vendor/guest with an email with only one domain label.

Screenshot 2024-11-15 at 4.34.21 PM.png Screenshot 2024-11-15 at 4.34.21 PM

Emails with only one domain label aren't on the internet and are only local networks. It may cause an inconvenience to users using this app as if they accidentally forget the '.' in the email, an email with 1 domain label is added into the system. When users use the system and try to contact a guest or company via email, it'll lead to invalid emails. Thus, the system should have in place something to stop the user from adding an email with only 1 domain label. Thus, this will be labelled as severity medium.


[original: nus-cs2103-AY2425S1/pe-interim#3067] [original labels: severity.Medium type.FeatureFlaw]

YangQF2002 commented 1 week ago

Team's Response

We acknowledge that this is a limitation of the email value. However, the likelihood of users accidentally entering an email with a single domain label is low, as most email addresses in real-world scenarios follow standard formats with multiple domain labels (e.g., @gmail.com, @yahoo.com). This edge case is unlikely to occur frequently. Additionally, most users are accustomed to seeing and entering correctly formatted email addresses due to widespread use of validation in online forms, further reducing the chances of this error. Thus, this limitation is a rare edge case. Hence, we feel that the severity should be low. That said, we recognize the potential value of this enhancement and will consider implementing it in future iterations to further refine the user experience.

Duplicate status (if any):

--