nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Data of application will be lost if failed to process the save data #2392

Open nus-pe-bot opened 6 days ago

nus-pe-bot commented 6 days ago

Description

When there is unexpected changes in the save file of the application (e.g. file corruption, edited by other programs such as AB3, or modified by the user), the application will clear all records when starting the application again.

This can be a big inconvenience for the unknowing users who have any of the examples mentioned above happen to them, and there is completely no visible warning or error shown to the user, and they are just instead prompted with an empty application.

Running any commands such as adding customers or orders will cause irreversible data loss.

Suggestions

Give a warning to the user that the application was unable to load the save file, and running any commands in the application will cause the data to be lost permanently.

(What if this happens to you using applications one day, all of a sudden you open the application and all your important information is gone! :scream:)


[original: nus-cs2103-AY2425S1/pe-interim#3255] [original labels: severity.Medium type.FeatureFlaw]

awdse22 commented 6 days ago

Team's Response

It is stated in user guide that direct changes to data file may cause this to happen (that SellSavvy will start with empty data file next run)

Screenshot_1726.png

However, we do agree that as part of an improvement, a warning could have at least been given. Though this is not very likely to happen as we operate under the assumption where it is not often users directly modify the data file often/data file does not get corrupted, hence severity is moved to low and this isn't too high in our priority compared to other features.

Duplicate status (if any):

--