nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Find command returns incorrect result #2473

Open nus-se-script opened 1 week ago

nus-se-script commented 1 week ago

When the command "find ui" is entered, one of the companies listed (i.e Microsoft) has no "ui" within tags, applications or name but it still appeared. The screen recording attached shows this scenario more clearly!


video:https://raw.githubusercontent.com/nus-cs2103-AY2425S1/pe/master/files/0ffbf822-3085-489e-b14a-f11c63d04e13.mov


[original: nus-cs2103-AY2425S1/pe-interim#1074] [original labels: severity.Medium type.FunctionalityBug]

meerkatboy commented 1 week ago

Team's Response

Good catch! However, this issue will be marked as low, and as a documentation bug.

While it may seem like an incorrect result was output, we did not specify in the User Guide that as long as any part of the company name, tags, application names and application details matches the keyword, the company will be displayed in the output. As a result, the results shown were due to the phrase "ui" being a part of the application details, which are hidden in the current list view. We will classify this as a documentation bug since this behaviour was not clearly documented in our User Guide.

This issue is also marked with a low severity as it will unlikely affect normal operations of InternBuddy, this confusion will be for users who have just started using InternBuddy, with a better understanding of the scope of the find command, this behaviour will not be viewed as faulty.

Duplicate status (if any):

--