nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Checks duplicates only by name does not fit for real life scenarios #2489

Open nus-se-script opened 1 week ago

nus-se-script commented 1 week ago

KnottyPlanners uses only names to distinguish contacts from one another. By in real-life scenarios, there can be many duplicated names by nature. Solely checking on names does not suit for real-life usage. A much more reasonable approach would be to distinguish by email address, because email address by nature, is unique and can be verified easily


[original: nus-cs2103-AY2425S1/pe-interim#3392] [original labels: type.FeatureFlaw severity.Low]

jonushzw commented 1 week ago

Team's Response

We put this as not in scope because we mentioned in our UG that you should add keywords to differentiate if you do have two people with the same name.

Screenshot 2024-11-18 at 1.18.33 AM.png

Duplicate status (if any):

--