nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

find command is not specific/efficient in finding names. #2771

Open nus-se-script opened 1 week ago

nus-se-script commented 1 week ago

Consider I have the following people in the data base:

Screenshot 2024-11-15 at 4.57.38 PM.png

When I enter the find command, ie find hui xuan, I get the following:

Screenshot 2024-11-15 at 4.58.13 PM.png

As a user, I would expect only the name Hui Xuan to be shown. However, more names (which I do not need) are being shown too. This will be a bigger issue if the database is larger, especially since these are very common Chinese names. This makes the find command slightly inefficient as the user would still have to manually look for the name Hui Xuan despite the find command being executed.

A suggestion would be to do a (case insensitive) string match. Or, introduce a new field eg do find Hui Xuan + Hui Ying to find 2 separate names (similar to Google)


[original: nus-cs2103-AY2425S1/pe-interim#3778] [original labels: severity.Medium type.FunctionalityBug]

junyi73 commented 1 week ago

Team's Response

This is addressed under the first enhancement listed under the future enhancement sections in our user guide. As this finding of names by sub-string may require an excess amount of effort, we deem it to be not-in-scope.

Duplicate status (if any):

--