search

nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Missing Red Cross in DG #2948

Open nus-pe-bot opened 1 week ago

nus-pe-bot commented 1 week ago

image.png

The DeleteCommand object should have a Red Cross at the end of its activation to indicate that it is no longer referenced.

[original: nus-cs2103-AY2425S1/pe-interim#1309] [original labels: type.DocumentationBug severity.VeryLow]

JoanneHing commented 1 week ago

Team's Response

Thank you for the feedback! Our team understand that X is used to indicate that the object is deleted or no longer referenced in the diagram, or ready to be garbage collected in Java. That is why the DeleteCommandParser is having a X after the parsing is done.

But the DeleteCommand is not ready to be garbage collected after the constructor call as it will be referenced later by LogicManager and it is referencing other object also until the very end of the operation. We would also like to clarify that X is not a compulsory notation in sequence diagram, as can be referenced in issue #821 in the course forum.

We appreciate your feedback but unfortunately our team do not agree with the bug reported.

Duplicate status (if any):

--