nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Disallows "s/o" As the Name of the Volunteer. #2995

Open nus-se-script opened 6 days ago

nus-se-script commented 6 days ago

스크린샷 2024-11-15 오후 5.07.02.png

Description The VolunSync does not allow user from entering the "s/o" as the name of the volunteer which might cause inconvenience to certain users of this app.

Steps to Reproduce:

  1. Open the app
  2. List the volunteers by entering "list".
  3. Type the add command with the name including "s/o".
  4. See the error message.

Expected Behaviour: The system should add the volunteer in the list of volunteers.

Actual Behaviour: Gives a error message providing the reason why the command does not work.

Disallowing "s/o" in a person name because "/" is used as a command delimiter is a potential problem as input is expected to match the legal name of the person.


[original: nus-cs2103-AY2425S1/pe-interim#1430] [original labels: type.FeatureFlaw severity.Low]

JovenSoh commented 6 days ago

Team's Response

Thanks for raising this issue.

However, It's indicated in the UG that the inputs that the command only accepts Non-accented alphanumeric and spaces only, 1-100 characters.

image.png

Additionally, it is also not as important to implement compared to other more pressing features as it can be easily overcome by using SO and DO instead of the /.

Finally, the command fails gracefully, and has an error message to indicate that it would only accept alphanumeric characters and spaces, therefore it should be classified as NotInScope

image.png

Duplicate status (if any):

--