Inconsistent/Incorrect error message when invalid index is given

[nus-pe-bot]

Summary

When the Index for a command (e.g. edit) is 0, the error given is related to "invalid command format", but when the Index given is more than the number of items listed, the error given is instead "The person index is invalid".

Steps to reproduce

1. Type edit 0 n/test
2. Observe error
3. Type edit 100 n/test given the number of persons listed is less than 100
4. Observe error

Expected

Both result in "The person index is invalid".

Observed

edit 0 n/test

edit 100 n/test

Tester Information

System Information:

• OS: NixOS 24.11.20240906.574d1ea (Vicuna) x86_64
• Kernel: 6.6.49
• Shell: zsh 5.9
• Resolution: 3000x2000
• DE: hyprland (Wayland)
• Terminal: foot
• CPU: 12th Gen Intel i7-1255U (12) @ 4.700GHz
• GPU: Intel Alder Lake-UP3 GT2 [Iris Xe Graphics]
• Memory: 5734MiB / 15691MiB

Java version:

• openjdk version "17.0.11" 2024-04-16
• OpenJDK Runtime Environment (build 17.0.11+9-nixos)
• OpenJDK 64-Bit Server VM (build 17.0.11+9-nixos, mixed mode, sharing)

---

_{[original: nus-cs2103-AY2425S1/pe-interim#453] [original labels: severity.Low type.FunctionalityBug]}

[Kitty-001]

Team's Response

Thanks for mentioning this issue, I think it's mentioned in the User Guide under note of the command edit. Because index is positive integer, so 0 is considered as invalid command, while out of bound positive integers are considered invalid index.

Duplicate status (if any):

--