nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Unable To Add Supplier Even Though Email Is Valid (Error Shown) #3733

Open nus-se-script opened 2 weeks ago

nus-se-script commented 2 weeks ago

Description

For the following command: add_supplier n/Fresh Farms Ltd p/98765432 e/a+_.-a@example.com a/23 Orchard Street, the email meets the constraints shown in the error message, yet the error is shown.

Screenshots

image.png

Expected

Supplier should have been added

Actual

Error given

Reason For Severity

Users will be confused when they try to add a supplier while following the given constraints. Given how the provided email matches the constraints and yet the error confusingly says otherwise, this will be a big inconvenience for the user.


[original: nus-cs2103-AY2425S1/pe-interim#3326] [original labels: severity.Medium type.FunctionalityBug]

Anvita2110 commented 1 week ago

Team's Response

Justification for Severity.low:

Emails with unusual formats like a+_.-a@example.com (with all special characters together) are extremely rare in real-world scenarios. Most users are likely to use conventional email addresses (e.g., john.doe@example.com), which are unaffected by this issue.

This bug is unlikely to occur often because:

With reference to the definition of severity.Low and severity.Medium:

image.png

Duplicate status (if any):

--