nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Invalid email address is allowed #3755

Open nus-pe-bot opened 1 week ago

nus-pe-bot commented 1 week ago

When the user input an invalid email address, the system simply add the person with an invalid email address in the list instead of raising a error message.

For example input add i/S5087089H n/John Doe p/98765432 e/123@45 a/John street, block 123, #01-01 c/7, the system will add the person.

截屏2024-11-15 16.23.08.png

This bug is a feature flaw as it will cause the inconvenience of the user and it will not raise a warning message, it needs users to check by themselves to find the error.


[original: nus-cs2103-AY2425S1/pe-interim#3375] [original labels: severity.Medium type.FeatureFlaw]

GabrielCWT commented 1 week ago

Team's Response

Under Planned Enhancements: Change validation of email: Currently, the email field is validated using a simple regex pattern. It might not be able to catch all invalid email addresses, and might reject some valid emails. We plan to change the validation to use a more robust email validation algorithm, based on this RFC 3696 standard.

We lowered the severity to Low since having more flexibility in the email validation is unlikely to affect normal operations of the product.

Duplicate status (if any):

--