Employee and Potential Command allows for adding people with same details

[nus-pe-bot]

Added 2 persons by typing the following into the command box:

employee n/John Doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 d/IT r/SWE ced/2024-10-09

and

employee n/John p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 d/IT r/SWE ced/2024-10-09

The app allows me to create 2 persons with the exact same details but only different name. I suppose the check for duplicates only uses the name field, but to the end user it does not really make sense as 2 different people cannot have the same details (eg phone number, address, email). Perhaps the team can use these fields to check for duplicates too or throw warning to user.

---

_{[original: nus-cs2103-AY2425S1/pe-interim#3809] [original labels: severity.Medium type.FunctionalityBug]}

[thortol]

Team's Response

Reason for dropping to severity low

This issue is unlikely to affect normal operations of the product as it only appears in rare situations where the user intentionally adds 2 users with the same details (phone number, address, email).

Reason for feature flaw

This is not a functionality bug as nowhere in the UG we promised users that we will validate that 2 users have the same details (phone number, address, email). Instead its a feature flaw as it is less useful as users may accidentally insert 2 users with the same details.

Reason for not in scope

This is a valid concern as users may want validation to prevent 2 users with the same details to be inserted (phone number, address, email). However, this is not in the scope as checking each field will take way more effort than the current implementation which is why we decided to leave it as not in scope.

Duplicate status (if any):

--