nus-cs2103-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Improve error message to users on invalid date #414

Open nus-pe-bot opened 1 week ago

nus-pe-bot commented 1 week ago

Steps to reproduce

  1. Type in any command that involves a date, and use an invalid date which exceed the number of days in that month. For example, makeup 1 dt/32-01-2025 st/10:00 et/12:00

Expected

There should be an error message informing users that the date entered should be within the number of days of that month.

Actual

There is an error message saying that: "Date should be a valid date in "DD-MM-YYYY" format.". This might be confusing to users since their data format is correct, in the form of DD-MM-YYYY.

How to improve the product

There can be an additional check to ensure the DD of the date entered is within the number of days in the month MM entered. The error message should be more specific in letting users know that the date should be within the valid number of days in the month, so that users find it easier to identify what went wrong in the date they entered.

Screenshot

Screenshot 2024-11-15 at 17.06.17.png


[original: nus-cs2103-AY2425S1/pe-interim#591] [original labels: type.FeatureFlaw severity.Low]

IzN432 commented 1 week ago

Team's Response

image.png

The error message says that it needs to be 1. A valid date 2. in DD-MM-YYYY. It would take extra effort to differentiate between the two and throw a different error message for it. So, we believe this is not in scope.

Duplicate status (if any):

--