nus-cs2113-AY2122S1 / pe-dev-response

0 stars 0 forks source link

Save file not filtered when name is the parser itself (|) #2922

Open nus-se-bot opened 2 years ago

nus-se-bot commented 2 years ago

When I change the name of my food to "|", an exception is thrown at the start of the program. Preventing the program to start. Perhaps a filter could be implemented for this. Screenshot 2021-11-12 at 4.30.16 PM.png

Screenshot 2021-11-12 at 4.31.01 PM.png

_{[original: nus-cs2113-AY2122S1/pe-interim#2889] [original labels: severity.Medium type.FunctionalityBug]}

alvynben commented 2 years ago

Team's Response

Thank you for this bug report. However, Fridget can actually to allow | from savedShop.txt.

The actual issue is that there is no space in between | and |. Thanks for letting us know.

We've chosen to reduce the severity of this bug report to Low for two main reasons:

Most users would not tamper with the txt files anyway. If they decided to do so, they would be skilled enough to edit it correctly.
The UG does state to not put | into the item's names.

Duplicate status (if any):

Duplicate of #2841