nus-cs2113-AY2425S1 / pe-dev-response

0 stars 0 forks source link

Inconsistent behaviour of delimiters and exceptions. #132

Open nus-pe-bot opened 1 week ago

nus-pe-bot commented 1 week ago

The CLI application uses the "-" character consistently as its delimiter for commands.

This would lead to the expected behaviour of the application to give an exception if the delimiter is followed by an appropriate command character, for instance "m". However, this is not the case as seen below:

image.png

In this case, the user is trying to input a manga named "Hi", to an author "someone". However, the application does not throw an error, and instead adds an author named "someone -mHi".

In addition, the user guide explicitly states that if the author's name contains a "-" character, the user should replace it with "--" instead. This means that it should throw an exception message if someone attempts to use the "-" character in the authors name.

Perhaps this issue should be rectified so that the user does not accidentally input wrong author names?


[original: nus-cs2113-AY2425S1/pe-interim#245] [original labels: severity.Low type.FunctionalityBug]

sarahchow03 commented 1 week ago

Team's Response

We believe that the tester misinterpreted our UG. A valid flag is considered as the whole token that is valid according to our pre-set flags set (i.e. -a or -d), not just - followed by some string. Our parser is able to detect when an invalid flag (such as -mHi) is inputted and it treats it as part of the valid argument that precedes it (i.e. the -a). This allows for the greatest flexibility for users in naming their author names/manga names. This is mentioned in our UG, where strings between valid flags are included (-mHi is not a valid flag, so it is treated as part of the string).

Duplicate status (if any):

--