nushell / tree-sitter-nu

A tree-sitter grammar for nu-lang, the language of nushell
MIT License
122 stars 27 forks source link

Unifying rules for command parsing #22

Closed SirZenith closed 1 year ago

SirZenith commented 1 year ago

Currently, there are two different rules for command parsing. One for sub commands like str join, another for simple command like echo.

This make application side difficult to tell the difference between echo this and str join, cause they are both being parsed as sub command.

And this two rules also make command with three or more name segments failed to parse.

fdncred commented 1 year ago

@SirZenith Thanks for this PR!

@1Kinoti Would you mind reviewing this PR and letting us know what you think?

1Kinoti commented 1 year ago

@SirZenith thanks for this.

a few nitpicks and we'll be good to go

1Kinoti commented 1 year ago

@fdncred this is good to go. thanks again @SirZenith

SirZenith commented 1 year ago

😄

fdncred commented 1 year ago

@fdncred this is good to go. thanks again @SirZenith

Thanks @1Kinoti and @SirZenith. We appreciate the support!!