Parser breaks with this syntax

[marcelarie]

With the type@'type' on the command parameter, the syntax highlighting breaks.

Example of the code:

export def-env main [
    command?: string@'nu-complete rbenv',
    ...args
] {
    let new_env = if $command in ["rehash", "shell"] {
        # implement each on indiviudaly e.g.
        if $command == "shell" {
            { RBENV_VERSION_OLD: $env.RBENV_VERSION RBENV_VERSION: $args.0 }
        } else {
            error make { msg: $"`($command)` command is not supported yet" }
        }
    } else {
        if ($command | is-empty) {
            ^rbenv
        } else {
            ^rbenv $command $args
        }
        {}
    }
    load-env $new_env
}

def 'nu-complete rbenv' [] {
    ^rbenv help
    | lines
    | where ($it | str starts-with "   ")
    | each {|entry| $entry | split row ' ' | get 0 }
}

Screenshoot:

[fdncred]

Thanks for the report! We need more hands on this repo. We only have a couple people who've done 99% of the work. Feel free to get your hands dirty and try to submit a PR.

[amtoine]

not sure i see the same in Neovim :open_mouth:

[marcelarie]

I am using neovim too, how strange. Maybe I have some plugin that breaks treesitter.

https://github.com/nushell/tree-sitter-nu/assets/62728887/a38bd21b-3405-488c-977e-ebcdc8cf2611

[amtoine]

:scream:

without looking at the config, the only difference i see is the extra export-env block you have at the top :smirk:

also, do you use the latest version of this TS?

[marcelarie]

I tried deleting that export-env and the result is the same:

[marcelarie]

I use the latest version I think, how can I check it?

[siph]

fwiw this highlighting looks fine with my neovim config as well.

[amtoine]

I use the latest version I think, how can I check it?

not sure, i've installed the queries from this repo manually so i do not have the revision attached to them i fear :confused:

[amtoine]

very strange, i just pulled the query file again and reinstalled the TS parser again with the following two scripts:

• toolkit update which calls...
• ... install-queries

and i still do not see this :cry:

[petrisch]

Did you check the :InspectTree for this? Cause with my colorscheme this doesn't break the highlight, however I see an ERROR on this line (26): | where ($it | str starts-with " ") right on the where keyword.

[petrisch]

I don't have a solution, but shouldn't there be optional punctuation, like brakets or parenthesis in the _where_predicate here?

where_command: ($) => seq("where", $._where_predicate),

    _where_predicate: ($) =>
      choice(
        ...TABLE().map(([precedence, opr]) =>
          prec.left(
            precedence,
...

Because this:

[["a" "b"];[3 4] [5 6]] | where ("a" < 4)

or this

[["a" "b"];[3 4] [5 6]] | where "a" < 4

breaks it for me also.

[fdncred]

where can have parentheses or braces since it's a closure.

[fdncred]

I'm not seeing any errors in the OP's script now (except moving from def-env to def --env). So, I'm closing this.

[fdncred]

oops, actually I do still see an error. Sorry. @kit494way is this something you'd be interested in fixing?

[kit494way]

yes. I will try.