nutanix-cloud-native / cluster-api-provider-nutanix

Kubernetes-native declarative infrastructure provider for Nutanix AHV
https://opendocs.nutanix.com/capx/latest/getting_started/
Apache License 2.0
42 stars 22 forks source link

remove CPU/Memory resources settings #369

Closed tuxtof closed 10 months ago

tuxtof commented 10 months ago

This PR fully removes the CPU/Memory limits as it is generally recommended not to enforce them.

goal is to align with other provider like CAPV/CAPA/CAPG

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (43b112e) 15.21% compared to head (03c395c) 15.21%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #369 +/- ## ======================================= Coverage 15.21% 15.21% ======================================= Files 18 18 Lines 1209 1209 ======================================= Hits 184 184 Misses 1025 1025 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thunderboltsid commented 10 months ago

/lgtm /approve

nutanix-cn-prow-bot[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thunderboltsid, tuxtof, yannickstruyf3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nutanix-cloud-native/cluster-api-provider-nutanix/blob/main/OWNERS)~~ [thunderboltsid,tuxtof,yannickstruyf3] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
thunderboltsid commented 10 months ago

/test e2e-capx-controller-upgrade