nutanix-cloud-native / cluster-api-provider-nutanix

Kubernetes-native declarative infrastructure provider for Nutanix AHV
https://opendocs.nutanix.com/capx/latest/getting_started/
Apache License 2.0
42 stars 22 forks source link

Update kustomization.yaml files to new format #387

Closed thunderboltsid closed 8 months ago

thunderboltsid commented 8 months ago

kustomize has deprecated the older format which our older kustomization files were based on. These older format files were leading to a lot of deprecation warnings from kustomize during our build processes.

We used kustomize edit fix command to update our old kustomize files to our new kustomize files. This PR was largely auto-generated using the following command.

$ find . -type d -exec bash -c 'cd {} && kustomize edit fix' \;
codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 25.63%. Comparing base (9ccfa89) to head (82f54f1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #387 +/- ## ======================================= Coverage 25.63% 25.63% ======================================= Files 19 19 Lines 1303 1303 ======================================= Hits 334 334 Misses 969 969 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

deepakm-ntnx commented 8 months ago

/hold

deepakm-ntnx commented 8 months ago

pls hold this change till we merge https://github.com/nutanix-cloud-native/cluster-api-provider-nutanix/pull/386/files as we are changing many yamls there as well. you can assign it to me so that i can do it after that

thunderboltsid commented 8 months ago

pls hold this change till we merge d2iq-labs/capi-runtime-extensions#384 as these are easy to make changes than the one done in d2iq-labs/capi-runtime-extensions#384

This changes the format of kustomization.yaml files to the ones expected by kustomize. This is pretty much an auto-generated change from kustomize linter. Can you clarify why the other PR is a blocker for this PR?

deepakm-ntnx commented 8 months ago

pls hold this change till we merge d2iq-labs/capi-runtime-extensions#384 as these are easy to make changes than the one done in d2iq-labs/capi-runtime-extensions#384

This changes the format of kustomization.yaml files to the ones expected by kustomize. This is pretty much an auto-generated change from kustomize linter. Can you clarify why the other PR is a blocker for this PR?

since we are making more changes in https://github.com/nutanix-cloud-native/cluster-api-provider-nutanix/pull/386 we can do this after above is merged

thunderboltsid commented 8 months ago

That makes sense. Given these changes are auto-generated anyway, it's easy enough to run the command again once the other PR is merged.

thunderboltsid commented 8 months ago

/hold cancel

thunderboltsid commented 8 months ago

/retest

thunderboltsid commented 8 months ago

/test e2e-nutanix-features