search

nuxsmin / docker-syspass

Docker stuff for running sysPass on Docker
GNU General Public License v3.0
39 stars 21 forks source link

Tag Docker images properly #4

Closed jdel closed 7 years ago

jdel commented 7 years ago

Would it be possible to tag Docker images properly with sysPass version ? I'd like to use it, but having only a latest tag offers zero control on my end.

Let me know if you want me to submit a PR for this. Thanks

nuxsmin commented 7 years ago

Sure, let me do some tweaks to the sysPass CVS branching so the tags would be set to the proper version number. That is so because the current master branch is for the stable version, so the latest tag is referring to that branch and it could be a bit confusing...

Thanks for the feedback!

jdel commented 7 years ago

Is there any reason why you maintain a different repo for Dockerfiles instead of having them directly in the branches of nuxsmin/sysPass ?

Docker hub allows you to do automated builds per branch / tags. This way when you create a new release on nuxsmin/sysPass a docker container is built automatically.

Edit: Documentation found here https://docs.docker.com/docker-cloud/builds/advanced/

Edit2: You can see a basic Dockerfile with args and a build hook for custom automated build here https://github.com/jdel/sspks

nuxsmin commented 7 years ago

Umm, that is so because the docker files project does not have any in common with the sysPass code and in my opinion, the main reason to use branches in a project development is the ability to split the project into workspaces so could work in each one and then merge (or not) the code between them, but keeping in mind that you're working on the same structure.

The Docker advanced automated builds are being used by using a tag for each directory in the project root.

captura_016

Thanks for the feedback!