search

nuxt-community / electron-template

Electron starter with nuxt.js
MIT License
251 stars 31 forks source link

[Question] Using this project #15

Closed alexandesigner closed 6 years ago

alexandesigner commented 6 years ago

Today to use this repository it is necessary to make a clone, why not add it to vue-cli so that users can only start it with vue init nuxt-community/electron-template <folder>, there is some restriction so you have not done so?

If it is the case I can send a PR with the changes

This question is available on Nuxt.js community (#c11)
fredgig commented 6 years ago

Attempting to npm run dev this template will cause an error (electron-userland/electron-compile#287). Apparently, using electron-webpack instead of electron-compile resolves the error according to the following issue:

Gum-Joe/tara#10

If possible, please keep this template up to date by utilizing webpacks!

HoraceKeung commented 6 years ago

Have a look at this https://github.com/HoraceKeung/nuxtron

alexandesigner commented 6 years ago

@HoraceKeung How cool, if you need any help to keep it, please let me know .. Maybe this repository can be merged with this, what do you think? @pi0

HoraceKeung commented 6 years ago

Thanks, I would love to contribute to this repo. As I have mentioned in https://nuxtjs.cmty.io/nuxt-community/electron-template/issues/c14, there are differences that has to be taken into consideration.

detrohutt commented 6 years ago

@HoraceKeung @alexandesigner I originally created this repo but "officially" stepped down as maintainer quite a while ago because I'm no longer using nuxt in my personal project (which takes up all my time). So I've been "out of the loop" for a long time and I'm not familiar with any of the changes that would be needed to update this repo, but I still have write access. If you guys can put together a pull request and test that it doesn't break any current behavior, I'll merge it.

HoraceKeung commented 6 years ago

@detrohutt I was trying to push a new branch but I may not have the permission.

detrohutt commented 6 years ago

@HoraceKeung You'll need to fork this repo, edit your fork with the necessary changes, and then open a pull request pointing to your fork.

HoraceKeung commented 6 years ago

@detrohutt Thanks, just submitted a pull request.

detrohutt commented 6 years ago

Thanks! I'll review it later tonight and if everything looks good I'll merge it. If not, I'll let you know what needs changing.

detrohutt commented 6 years ago

Nuxtron has been merged with this repo. The original version of electron-template is available on the git-clone branch.

alexandesigner commented 6 years ago

Awesome @detrohutt, thank you!