search

nuxt-modules / turnstile

🔥 Cloudflare Turnstile integration for Nuxt
https://cloudflare.com/products/turnstile
MIT License
230 stars 18 forks source link

chore(component): remove `nextTick` #295

Closed dargmuesli closed 2 months ago

dargmuesli commented 8 months ago

Both mentioned issues are resolved now.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c564106) 19.26% compared to head (8aa2a4d) 19.34%.

Files Patch % Lines
src/runtime/components/NuxtTurnstile.vue 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #295 +/- ## ========================================== + Coverage 19.26% 19.34% +0.07% ========================================== Files 12 12 Lines 493 491 -2 Branches 23 23 ========================================== Hits 95 95 + Misses 398 396 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

danielroe commented 8 months ago

Nice! Have you confirmed that client-side navigation to a page with the Turnstile component still works?

dargmuesli commented 8 months ago

Yes, to the best of my knowledge: I enabled the playground widgets to load right away, navigated to /home and back and I noticed no issues.

danielroe commented 2 months ago

I think this is no longer relevant with Nuxt Scripts implementation

dargmuesli commented 2 months ago

Right, I think so too :rocket: