nuxt-modules / turnstile

๐Ÿ”ฅ Cloudflare Turnstile integration for Nuxt
https://cloudflare.com/products/turnstile
MIT License
240 stars 18 forks source link

chore(component): remove `nextTick` #337

Closed dargmuesli closed 2 months ago

dargmuesli commented 2 months ago

๐Ÿ”— Linked issue

I suggested this earlier in #295 already and we decided to wait for the scripts migration which is now done. The playground demo works without nextTick for me. As the upstream issues mentioned in code are resolved, I think we can remove nextTick now.

โ“ Type of change

๐Ÿ“š Description

Removes a await nextTick that does not appear to be required anymore.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 25.23%. Comparing base (dc164cc) to head (109315d). Report is 78 commits behind head on main.

Files with missing lines Patch % Lines
src/runtime/components/NuxtTurnstile.vue 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #337 +/- ## ========================================== + Coverage 19.26% 25.23% +5.96% ========================================== Files 12 11 -1 Lines 493 321 -172 Branches 23 22 -1 ========================================== - Hits 95 81 -14 + Misses 398 240 -158 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dargmuesli commented 2 months ago

I'm haven't looked at nuxt scripts in detail yet (only while it was in alpha) so I'm not certain which callback usage you reference exactly. May I ask you to push the changes for me too see and learn?