Add code sniffer and psr 12

nvanheuverzwijn / monolog-logdna

GNU Lesser General Public License v3.0

21 stars 21 forks source link

Add code sniffer and psr 12 #20

Closed slepic closed 9 months ago

slepic commented 10 months ago

Hi,

I added squizlabs/php_codesniffer to require-dev Also added cs-check and cs-fix directives to Makefile. I haven't yet added the fixed code style changes, because it would conflict with the other PRs, but i will push it when the others are merged or closed.

This should ideally be done in build pipeline which there is none yet, so I added at least this simple cs to the local dev stack....

nvanheuverzwijn commented 10 months ago

@slepic add documentation in README about this. I don't mind adding this kind of stuff as long as it's useful. I'll test the PR see how it works from my end.

nvanheuverzwijn commented 10 months ago

@slepic I just updated the dependencies in my last commit. You should rebase and re-run composer.

nvanheuverzwijn commented 10 months ago

@slepic I just committed your PR into master and fixed the issues it found. Cheers!