nvim-lua / completion-nvim

A async completion framework aims to provide completion to neovim's built in LSP written in Lua
Apache License 2.0
973 stars 78 forks source link

Enable LSP client snippet capabilities when snippet integration is configured #258

Open clason opened 4 years ago

clason commented 4 years ago

Neovim just merged a PR (https://github.com/neovim/neovim/pull/13183) that sets capabilities.textDocument.completion.completionItem.snippetSupport = false by default.

Now users have to remember to enable it themselves; it would be convenient if completion-nvim set that capability automatically when integration of one of the supported snippet plugins is configured.

@runiq

smartding commented 4 years ago

this only affects snippets from lsp server, right? no need to change anything if I'm using ultisnips.

clason commented 4 years ago

this only affects snippets from lsp server, right? no need to change anything if I'm using ultisnips.

Yes.

haorenW1025 commented 4 years ago

This could be nice, I'll implement this when I have some spare time(not now, unfortunately:cry:)