search

nvim-neorocks / luarocks-tag-release

GitHub workflow for automatically generating Luarocks releases from tags and running busted tests
GNU Affero General Public License v3.0
47 stars 3 forks source link

`neolua` -> `nlua` #430

Closed vhyrro closed 3 months ago

vhyrro commented 3 months ago

Related to neorocks itself but applicable here, feel free to let me know if I should transfer it over there.

Regular users are likely to bundle their projects with nlua as a test dependency and specify that as their Lua interpreter in their .busted file.

This causes tests run by luarocks-tag-release to fail, since it'll try to execute a nonexistent nlua binary. This should be fixable by making neorocks use nlua as the binary name instead of neolua.

mrcjkb commented 3 months ago

I'm wondering if it's best to just disable/deprecate running tests in favour of https://github.com/nvim-neorocks/nvim-busted-action, which can be chained with this one.

vhyrro commented 3 months ago

I think separating the two is a good call. Let this CI focus solely on luarocks releases, and let the busted action do the testing :)

mikavilpas commented 3 months ago

In my case my test suite has dependencies to an external application being installed on the system. Would be great to leave testing out of the release step. 🙂